Skip to content

[beta] Prepare Rust 1.89.0 #142920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 24, 2025
Merged

[beta] Prepare Rust 1.89.0 #142920

merged 3 commits into from
Jun 24, 2025

Conversation

cuviper
Copy link
Member

@cuviper cuviper commented Jun 23, 2025 •
edited by rustbot
Loading

r? cuviper

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc O-android Operating system: Android O-linux Operating system: Linux S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jun 23, 2025
@cuviper
Copy link
Member Author

cuviper commented Jun 23, 2025

@bors r+ rollup=never p=10

@bors
Copy link
Collaborator

bors commented Jun 23, 2025

📌 Commit 9909800 has been approved by cuviper

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 23, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@ehuss
Copy link
Contributor

ehuss commented Jun 23, 2025

@bors r-

Looks like there are some test failures.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 23, 2025
@cuviper
Copy link
Member Author

cuviper commented Jun 23, 2025

Yeah, some normalize-stderr regexes are not including the last .1 of version 1.89.0-beta.1. I'll send a fix.

@cuviper cuviper mentioned this pull request Jun 23, 2025
Merged
cuviper added 3 commits June 23, 2025 14:13
@cuviper
Update version placeholders
36b5dd0
@cuviper
Update channel to beta
af92bf6
@cuviper
Account for beta revisions when normalizing versions
7af995f 
Several UI tests have a `normalize-stderr` for "you are using x.y.z"
rustc versions, and that regex is flexible enough for suffixes like
"-nightly" and "-dev", but not for "-beta.N". We can just add '.' to
that trailing pattern to include this.

(cherry picked from commit 8469966)
@cuviper
Copy link
Member Author

cuviper commented Jun 23, 2025

I'm jumping the process a little bit to include #142930 without waiting for master, especially because that fix is basically a no-op until we get to beta versions anyway.

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 23, 2025

📌 Commit 7af995f has been approved by cuviper

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 23, 2025
@bors
Copy link
Collaborator

bors commented Jun 23, 2025

⌛ Testing commit 7af995f with merge 390a0ab...

@cuviper cuviper mentioned this pull request Jun 23, 2025
Closed
2 tasks
@bors
Copy link
Collaborator

bors commented Jun 24, 2025

☀️ Test successful - checks-actions
Approved by: cuviper
Pushing 390a0ab to beta...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 24, 2025
@bors bors merged commit 390a0ab into rust-lang:beta Jun 24, 2025
11 checks passed
@rustbot rustbot added this to the 1.89.0 milestone Jun 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cuviper cuviper

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. O-android Operating system: Android O-linux Operating system: Linux S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.89.0
Development

Successfully merging this pull request may close these issues.
5 participants
@cuviper @bors @rust-log-analyzer @ehuss @rustbot